Conversation
syvb
reviewed
Oct 19, 2020
| setData(statStorage, file, createWebpackData(stats)); | ||
| setData(fileStorage, file, createWebpackData(contents)); | ||
| self._compiler.fileTimestamps instanceof Map && | ||
| self._compiler.fileTimestamps.set(file, +stats.mtime); |
There was a problem hiding this comment.
Wouldn't removing this cause issues for webpack 4?
Member
Author
There was a problem hiding this comment.
fileWatcher.directoryWatcher.setFileTime call added in this PR should work both for Webpack 4 and Webpack 5, at least, when I checked it worked for me, we lack proper automated tests now and they are hard to write, so yeah, if you noticed that this change breaks something, please open an issue.
syvb
added a commit
to syvb/svelte-loader
that referenced
this pull request
Oct 21, 2020
Integrates the changes from: sysgears/webpack-virtual-modules#69
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Webpack 5 watch mode support is broken at the moment. Fixes: #68
How did you fix it?
I have added virtual files mtime propagation into new
watchpackversion.